Re: Review Request 16759: Patch for KAFKA-1199

2014-01-13 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16759/#review31635 --- Ship it! Ship It! - Jun Rao On Jan. 12, 2014, 11:10 p.m., Neha N

Re: Review Request 16759: Patch for KAFKA-1199

2014-01-12 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16759/ --- (Updated Jan. 12, 2014, 11:10 p.m.) Review request for kafka. Bugs: KAFKA-119

Re: Review Request 16759: Patch for KAFKA-1199

2014-01-12 Thread Neha Narkhede
- Neha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16759/#review31555 --- On Jan. 12, 2014, 10:58 p.m., Neha Narkhede wrote: > > --

Re: Review Request 16759: Patch for KAFKA-1199

2014-01-12 Thread Neha Narkhede
> On Jan. 10, 2014, 11:23 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/api/RequestOrResponse.scala, lines 41-45 > > > > > > It seems that this could be useful for the responses as well in the > > future to contro

Re: Review Request 16759: Patch for KAFKA-1199

2014-01-12 Thread Neha Narkhede
> On Jan. 10, 2014, 1 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala, line 196 > > > > > > I think the leaders info can also be put as detailed information, since > > it is simp

Re: Review Request 16759: Patch for KAFKA-1199

2014-01-12 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16759/ --- (Updated Jan. 12, 2014, 10:58 p.m.) Review request for kafka. Bugs: KAFKA-119

Re: Review Request 16759: Patch for KAFKA-1199

2014-01-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16759/#review31555 --- For non-detailed description, would it be useful to include #partiti

Re: Review Request 16759: Patch for KAFKA-1199

2014-01-09 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16759/#review31500 --- Ship it! core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala <

Review Request 16759: Patch for KAFKA-1199

2014-01-09 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16759/ --- Review request for kafka. Bugs: KAFKA-1199 https://issues.apache.org/jira/b