Re: Review Request 16360: Patch for KAFKA-1188

2014-02-13 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/#review34406 --- Ship it! Only minor comments core/src/main/scala/kafka/cluster/P

Re: Review Request 16360: Patch for KAFKA-1188

2014-02-11 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/ --- (Updated Feb. 12, 2014, 1:58 a.m.) Review request for kafka. Bugs: KAFKA-1188

Re: Review Request 16360: Patch for KAFKA-1188

2014-02-11 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/ --- (Updated Feb. 12, 2014, 1:58 a.m.) Review request for kafka. Bugs: KAFKA-1188

Re: Review Request 16360: Patch for KAFKA-1188

2014-02-11 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/ --- (Updated Feb. 12, 2014, 1:49 a.m.) Review request for kafka. Bugs: KAFKA-1188

Re: Review Request 16360: Patch for KAFKA-1188

2014-02-11 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/ --- (Updated Feb. 12, 2014, 1:48 a.m.) Review request for kafka. Bugs: KAFKA-1188

Re: Review Request 16360: Patch for KAFKA-1188

2014-01-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/ --- (Updated Jan. 21, 2014, 10:01 p.m.) Review request for kafka. Summary (update

Re: Review Request 16360: Patch for KAFKA-1188

2013-12-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/#review30768 --- core/src/main/scala/kafka/cluster/Partition.scala

Re: Review Request 16360: Patch for KAFKA-1188

2013-12-20 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/#review30767 --- Thanks for the patch. Some comments. core/src/main/scala/kafka/clu

Review Request 16360: Patch for KAFKA-1188

2013-12-18 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/ --- Review request for kafka. Bugs: KAFKA-1188 https://issues.apache.org/jira/b