Re: Review Request 16095: Patch for KAFKA-1170

2013-12-08 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16095/#review29963 --- Ship it! Ship It! - Guozhang Wang On Dec. 7, 2013, 12:22 a.m., N

Re: Review Request 16095: Patch for KAFKA-1170

2013-12-06 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16095/ --- (Updated Dec. 7, 2013, 12:22 a.m.) Review request for kafka. Bugs: KAFKA-1170

Re: Review Request 16095: Patch for KAFKA-1170

2013-12-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16095/#review29935 --- Ship it! Just one minor comment below. core/src/main/scala/kafka/

Re: Review Request 16095: Patch for KAFKA-1170

2013-12-06 Thread Neha Narkhede
> On Dec. 6, 2013, 11:37 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 216 > > > > > > Shall we keep it still as one logging entry so that we know these > > partitions are

Re: Review Request 16095: Patch for KAFKA-1170

2013-12-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16095/#review29930 --- core/src/main/scala/kafka/controller/ReplicaStateMachine.scala

Review Request 16095: Patch for KAFKA-1170

2013-12-06 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16095/ --- Review request for kafka. Bugs: KAFKA-1170 https://issues.apache.org/jira/b