Re: Review Request 15964: Patch for KAFKA-1156

2013-12-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15964/#review29777 --- Ship it! Ship It! - Guozhang Wang On Dec. 4, 2013, 12:22 a.m., N

Re: Review Request 15964: Patch for KAFKA-1156

2013-12-03 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15964/#review29692 --- Ship it! Ship It! - Jun Rao On Dec. 4, 2013, 12:22 a.m., Neha Na

Re: Review Request 15964: Patch for KAFKA-1156

2013-12-03 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15964/ --- (Updated Dec. 4, 2013, 12:22 a.m.) Review request for kafka. Bugs: KAFKA-1156

Re: Review Request 15964: Patch for KAFKA-1156

2013-12-03 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15964/ --- (Updated Dec. 4, 2013, 12:20 a.m.) Review request for kafka. Bugs: KAFKA-1156

Re: Review Request 15964: Patch for KAFKA-1156

2013-12-03 Thread Neha Narkhede
> On Dec. 3, 2013, 10:46 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, lines > > 181-182 > > > > > > Could we put the sentence starting from Save in a new line? Also, may >

Re: Review Request 15964: Patch for KAFKA-1156

2013-12-03 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15964/#review29688 --- core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala

Re: Review Request 15964: Patch for KAFKA-1156

2013-12-03 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15964/#review29684 --- core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala

Re: Review Request 15964: Patch for KAFKA-1156

2013-12-03 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15964/ --- (Updated Dec. 3, 2013, 6:21 p.m.) Review request for kafka. Bugs: KAFKA-1156

Re: Review Request 15964: Patch for KAFKA-1156

2013-12-03 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15964/ --- (Updated Dec. 3, 2013, 2:37 p.m.) Review request for kafka. Bugs: KAFKA-1156

Review Request 15964: Patch for KAFKA-1156

2013-12-03 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15964/ --- Review request for kafka. Bugs: KAFKA-1156 https://issues.apache.org/jira/b