Re: Review Request 15938: replicas may not have consistent data after becoming follower

2013-12-02 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15938/#review29622 --- Ship it! Ship It! - Neha Narkhede On Dec. 1, 2013, 11:33 p.m., J

Re: Review Request 15938: replicas may not have consistent data after becoming follower

2013-12-02 Thread Neha Narkhede
> On Dec. 2, 2013, 4:55 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 396 > > > > > > We had added the ability for a special consumer to read the replica log > > for troubleshoo

Re: Review Request 15938: replicas may not have consistent data after becoming follower

2013-12-02 Thread Neha Narkhede
> On Dec. 2, 2013, 4:55 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 396 > > > > > > We had added the ability for a special consumer to read the replica log > > for troubleshoo

Re: Review Request 15938: replicas may not have consistent data after becoming follower

2013-12-02 Thread Jun Rao
> On Dec. 2, 2013, 4:55 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 329 > > > > > > Do we still need this "TODO: the above may need to be fixed later" ? Yes, this can be

Re: Review Request 15938: replicas may not have consistent data after becoming follower

2013-12-02 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15938/#review29586 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 15938: replicas may not have consistent data after becoming follower

2013-12-01 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15938/#review29576 --- Ship it! core/src/main/scala/kafka/api/RequestOrResponse.scala

Review Request 15938: replicas may not have consistent data after becoming follower

2013-12-01 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15938/ --- Review request for kafka. Bugs: KAFKA-1154 https://issues.apache.org/jira/b