Re: Review Request 15805: KAFKA-1140.v2: addressed Jun's comments

> On Nov. 26, 2013, 2:45 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala, lines > > 102-103 > > > > > > We probably should just use ConsumerConfig.ConsumerTimeoutMs here, to

RE: Review Request 15805: KAFKA-1140.v2: addressed Jun's comments

: Review Request 15805: KAFKA-1140.v2: addressed Jun's comments This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15805/ Thinking about this a bit more. It seems that a better approach is to move the decoding into MessageAndMetadata. We define two me

Re: Review Request 15805: KAFKA-1140.v2: addressed Jun's comments

om:* Jun Rao [nore...@reviews.apache.org] on behalf of Jun Rao [ > jun...@gmail.com] > *Sent:* Tuesday, November 26, 2013 9:30 AM > *To:* kafka; Jun Rao; Guozhang Wang > *Subject:* Re: Review Request 15805: KAFKA-1140.v2: addressed Jun's > comments > > This is an aut

Re: Review Request 15805: KAFKA-1140.v2: addressed Jun's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15805/#review29438 --- Thinking about this a bit more. It seems that a better approach is t

Re: Review Request 15805: KAFKA-1140.v2: addressed Jun's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15805/#review29412 --- core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala

Re: Review Request 15805: KAFKA-1140.v2: addressed Jun's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15805/ --- (Updated Nov. 25, 2013, 8:55 p.m.) Review request for kafka. Bugs: KAFKA-1140

Re: Review Request 15805: KAFKA-1140.v2: addressed Jun's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15805/ --- (Updated Nov. 25, 2013, 8:53 p.m.) Review request for kafka. Summary (updated