Re: Review Request 15674: move LogCleanerManager to a separate file and improve unit test

2014-01-07 Thread Jun Rao
> On Jan. 7, 2014, 11:42 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/common/OptimisticLockFailureException.scala, line > > 23 > > > > > > Is this change intended? This is a diff btw v6 and v7, but is no

Re: Review Request 15674: move LogCleanerManager to a separate file and improve unit test

2014-01-07 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/#review31322 --- Ship it! Other than the question below, I think this patch looks go

Re: Review Request 15674: move LogCleanerManager to a separate file and improve unit test

2014-01-07 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/ --- (Updated Jan. 7, 2014, 6:51 p.m.) Review request for kafka. Summary (updated)

Re: Review Request 15674: move LogCleanerManager to a separate file and improve unit test

2014-01-07 Thread Jun Rao
> On Jan. 6, 2014, 9:18 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/log/LogCleaner.scala, line 161 > > > > > > the method description says it should block until the cleaner has > > processed upto the give