Re: Review Request 15201: address more review comments

2013-11-14 Thread Jun Rao
> On Nov. 13, 2013, 2:09 a.m., Joel Koshy wrote: > > Looks good overall - this is definitely a useful tool to have. I'm posting > > comments so far but I will come back to it tomorrow to finish up. > > > > So what would be the recommended procedure when the tool reports an > > inconsistency? W

Re: Review Request 15201: address more review comments

2013-11-14 Thread Jun Rao
> On Nov. 13, 2013, 7:43 a.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala, line 70 > > > > > > fetchsize -> fetch-size for consistency with other options? changed. > On Nov

Re: Review Request 15201: address more review comments

2013-11-12 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/#review28781 --- core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala

Re: Review Request 15201: address more review comments

2013-11-12 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/#review28744 --- Looks good overall - this is definitely a useful tool to have. I'm p

Re: Review Request 15201: address more review comments

2013-11-12 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/ --- (Updated Nov. 12, 2013, 4:34 p.m.) Review request for kafka. Summary (updated