Re: Review Request 14730: Patch for KAFKA-1001

2013-10-29 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14730/ --- (Updated Oct. 29, 2013, 6:27 p.m.) Review request for kafka. Summary (updated

Re: Review Request 14730: Patch for KAFKA-1001

2013-10-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14730/ --- (Updated Oct. 28, 2013, 6:19 p.m.) Review request for kafka. Summary (updated

Re: Review Request 14730: Patch for KAFKA-1001

2013-10-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14730/#review27309 --- core/src/main/scala/kafka/server/AbstractFetcherManager.scala

Re: Review Request 14730: Patch for KAFKA-1001

2013-10-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14730/ --- (Updated Oct. 21, 2013, 8:35 p.m.) Review request for kafka. Bugs: KAFKA-1001

Re: Review Request 14730: Patch for KAFKA-1001

2013-10-18 Thread Guozhang Wang
> On Oct. 18, 2013, 5:34 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/AbstractFetcherManager.scala, line 140 > > > > > > We need to think through this change. What if a broker is restarted > > quickly wit

Re: Review Request 14730: Patch for KAFKA-1001

2013-10-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14730/#review27195 --- Thanks for the patch. Using ._1 and ._2 tend to be confusing since i

Review Request 14730: Patch for KAFKA-1001

2013-10-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14730/ --- Review request for kafka. Bugs: KAFKA-1001 https://issues.apache.org/jira/b