Re: command line tools

2014-03-10 Thread Martin Kleppmann
+1 for using exit status in the command-line tools. The other day I wanted to modify a shell script to create a Kafka topic, using bin/kafka-topics.sh --create --topic ... The tool's behaviour is not very conducive to automation: - If the topic creation was successful, it prints out a message a

Re: command line tools

2014-03-10 Thread Michael G. Noll
Oh, and one more comment: I haven't checked all the CLI tools of Kafka in that regard, but preferably each tool would properly return zero exit codes on success and non-zero on failure (and possibly distinct error exit codes). That would simplify integration with tools like Puppet, Chef, Ansibl

Re: command line tools

2014-03-08 Thread Michael G. Noll
I just happen to come across that message. As someone who is a mere Kafka user take my feedback with a grain of salt. On 03/05/2014 05:01 AM, Jay Kreps wrote: > Personally I don't mind the current approach as it is discoverable and > works with tab completion. Having typical shell features such

Re: command line tools

2014-03-04 Thread Jay Kreps
Personally I don't mind the current approach as it is discoverable and works with tab completion. I wouldn't be opposed to replacing kafka-run-class.sh with a generic kafka script that handles the java and logging options and maintaining a human friendly mapping for some of the class names so that

Re: command line tools

2014-03-04 Thread Joe Stein
How about a kafka-system-tool.sh and a little bash/scala underneath to delegate which tool is asked for and passes the params from cli to object? kafka-system-tool.sh -h would respond with the list of tools and kafka-system-tool.sh toolName -h would respond with the actual tool's args from the to