Thanks guys for your feedback.
Matthias, we can change the config to use JavaDoc (1 space) instead of the
Scala doc (2 space), that would limit the change indeed.
When I say we can apply this change module by module I mean we can specify
folders, so we could breakdown core too.
I updated the PR
It certainly annoys me every time I open the code and my linter starts
highlighting that some code is indented with spaces and some with tabs...
increasing consistency across the codebase would be appreciated.
On Wed, May 9, 2018 at 9:10 PM, Ismael Juma wrote:
> Sounds good about doing this for
Sounds good about doing this for Kafka streams scala first. Core is a bit
more complicated so may require more discussion.
Ismael
On Wed, 9 May 2018, 16:59 Matthias J. Sax, wrote:
> Joan,
>
> thanks for starting this initiative. I am overall +1
>
> However, I am worried about applying it to `co
Joan,
thanks for starting this initiative. I am overall +1
However, I am worried about applying it to `core` module as the change
is massive. For the Kafka Streams Scala module, that is new and was not
released yet, I am +1.
A personal thing about the style: the 2-space indention for JavaDocs is
Hi Ted,
As far as I understand this is an issue for PRs and back porting the
changes to other branches.
Applying the tool to the other branches should also resolve the conflicts
as the formattings will match, leaving only the actual changes in the diffs.
That's what we did sometime ago at my work
Applying the tool across code base would result in massive changes.
How would this be handled ?
Original message From: Joan Goyeau Date:
5/9/18 3:31 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Use of a
formatter like Scalafmt
Hi,
Contributing to Kafka Streams' Scala API
