Re: Review Request 36034: Patch for KAFKA-2306

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/#review90765 --- Ship it! Ship It! - Guozhang Wang On July 7, 2015, 5:47 p.m., Do

Re: Review Request 36034: Patch for KAFKA-2306

> On July 7, 2015, 5:28 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 408 > > > > > > Missed one more point here: I think it is better to use >

Re: Review Request 36034: Patch for KAFKA-2306

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/ --- (Updated July 7, 2015, 5:47 p.m.) Review request for kafka and Joel Koshy. Bu

Re: Review Request 36034: Patch for KAFKA-2306

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/#review90730 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

Re: Review Request 36034: Patch for KAFKA-2306

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/#review90712 --- Ship it! Ship It! - Guozhang Wang On July 7, 2015, 1:22 a.m., Do

Re: Review Request 36034: Patch for KAFKA-2306

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/ --- (Updated July 7, 2015, 1:22 a.m.) Review request for kafka and Joel Koshy. Bu

Re: Review Request 36034: Patch for KAFKA-2306

> On July 7, 2015, 12:25 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 254 > > > > > > I think we do not need to create a varialbe here since it

Re: Review Request 36034: Patch for KAFKA-2306

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/#review90614 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

Re: Review Request 36034: Patch for KAFKA-2306

> On July 3, 2015, 1:36 a.m., Guozhang Wang wrote: > > Thanks for the patch. I have a few thoughts regarding the names of the > > metrics, since in the producer other causes can also result in dropped > > messages (i.e. rejected before it enteres the producer buffer), such as > > message-size-

Re: Review Request 36034: Patch for KAFKA-2306

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/ --- (Updated July 6, 2015, 9:54 p.m.) Review request for kafka and Joel Koshy. Bu

Re: Review Request 36034: Patch for KAFKA-2306

> On July 3, 2015, 1:36 a.m., Guozhang Wang wrote: > > Thanks for the patch. I have a few thoughts regarding the names of the > > metrics, since in the producer other causes can also result in dropped > > messages (i.e. rejected before it enteres the producer buffer), such as > > message-size-

Re: Review Request 36034: Patch for KAFKA-2306

> On July 3, 2015, 1:36 a.m., Guozhang Wang wrote: > > Thanks for the patch. I have a few thoughts regarding the names of the > > metrics, since in the producer other causes can also result in dropped > > messages (i.e. rejected before it enteres the producer buffer), such as > > message-size-

Re: Review Request 36034: Patch for KAFKA-2306

> On July 3, 2015, 1:36 a.m., Guozhang Wang wrote: > > Thanks for the patch. I have a few thoughts regarding the names of the > > metrics, since in the producer other causes can also result in dropped > > messages (i.e. rejected before it enteres the producer buffer), such as > > message-size-

Re: Review Request 36034: Patch for KAFKA-2306

> On July 3, 2015, 1:36 a.m., Guozhang Wang wrote: > > Thanks for the patch. I have a few thoughts regarding the names of the > > metrics, since in the producer other causes can also result in dropped > > messages (i.e. rejected before it enteres the producer buffer), such as > > message-size-

Re: Review Request 36034: Patch for KAFKA-2306

> On July 3, 2015, 1:36 a.m., Guozhang Wang wrote: > > Thanks for the patch. I have a few thoughts regarding the names of the > > metrics, since in the producer other causes can also result in dropped > > messages (i.e. rejected before it enteres the producer buffer), such as > > message-size-

Re: Review Request 36034: Patch for KAFKA-2306

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36034/#review90303 --- Thanks for the patch. I have a few thoughts regarding the names of t