Re: Review Request 35655: Patch for KAFKA-2271

2015-06-22 Thread Ewen Cheslack-Postava
> On June 22, 2015, 11:43 p.m., Ewen Cheslack-Postava wrote: > > LGTM. There were 9 question marks when 10 characters were requested, so the > > problem was probably just that a whitespace character at the start or end > > would get trimmed during AbstractConfig's parsing. > > Jason Gustafson

Re: Review Request 35655: Patch for KAFKA-2271

2015-06-22 Thread Jason Gustafson
> On June 21, 2015, 5:49 a.m., Guozhang Wang wrote: > > I think the main reason is that util.Random.nextString() may include other > > non-ascii chars and hence its toString may not be well-defined: > > > > http://alvinalexander.com/scala/creating-random-strings-in-scala > > > > So I think bot

Re: Review Request 35655: Patch for KAFKA-2271

2015-06-22 Thread Jason Gustafson
> On June 22, 2015, 11:43 p.m., Ewen Cheslack-Postava wrote: > > LGTM. There were 9 question marks when 10 characters were requested, so the > > problem was probably just that a whitespace character at the start or end > > would get trimmed during AbstractConfig's parsing. That's what I though

Re: Review Request 35655: Patch for KAFKA-2271

2015-06-22 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35655/#review88877 --- Ship it! LGTM. There were 9 question marks when 10 characters were

Re: Review Request 35655: Patch for KAFKA-2271

2015-06-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35655/#review88690 --- I think the main reason is that util.Random.nextString() may include