Re: Review Request 35437: Patch for KAFKA-2202

2015-08-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35437/#review94866 --- Ship it! Ship It! - Guozhang Wang On June 14, 2015, 11:27 a.m.,

Re: Review Request 35437: Patch for KAFKA-2202

2015-08-10 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35437/#review94836 --- Ship it! LGTM. Verified it gets rid of KAFKA-1828 too. - Ewen Ches

Re: Review Request 35437: Patch for KAFKA-2202

2015-06-14 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35437/#review87876 --- This patch only addresses the old consumer. Can you check if the rat