Re: Review Request 35187: Fix KAFKA-2253

2015-06-07 Thread Guozhang Wang
> On June 7, 2015, 6:08 p.m., Jiangjie Qin wrote: > > Is it still possible that in tryCompleteElseWatch after we get the watcher > > from watchersForKey() but before we call watchers.watch(), that watcher get > > removed from purgatory? If so, is it possible that operation got lost? Ack. > O

Re: Review Request 35187: Fix KAFKA-2253

2015-06-07 Thread Guozhang Wang
> On June 7, 2015, 6:03 a.m., Onur Karaman wrote: > > core/src/main/scala/kafka/server/DelayedOperation.scala, line 262 > > > > > > Forgot to mention that the commented out code should be removed. Ack. - Guozhang

Re: Review Request 35187: Fix KAFKA-2253

2015-06-07 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35187/#review86972 --- Is it still possible that in tryCompleteElseWatch after we get the w

Re: Review Request 35187: Fix KAFKA-2253

2015-06-06 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35187/#review86951 --- core/src/main/scala/kafka/server/DelayedOperation.scala

Re: Review Request 35187: Fix KAFKA-2253

2015-06-06 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35187/#review86950 --- Ship it! Ship It! - Onur Karaman On June 7, 2015, 4:49 a.m., Guo