Re: Review Request 34394: Patch for KAFKA-1907

2015-05-29 Thread Jaikiran Pai
> On May 29, 2015, 7:11 a.m., Joe Stein wrote: > > core/src/main/scala/kafka/utils/ZkUtils.scala, line 39 > > > > > > if we are going to add this it should be exposed as a configuration and > > written up in a KIP. We

Re: Review Request 34394: Patch for KAFKA-1907

2015-05-29 Thread Joe Stein
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34394/#review85691 --- core/src/main/scala/kafka/utils/ZkUtils.scala

Re: Review Request 34394: Patch for KAFKA-1907

2015-05-24 Thread Jaikiran Pai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34394/ --- (Updated May 25, 2015, 3:49 a.m.) Review request for kafka. Bugs: KAFKA-1907

Re: Review Request 34394: Patch for KAFKA-1907

2015-05-18 Thread Jaikiran Pai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34394/ --- (Updated May 19, 2015, 5:20 a.m.) Review request for kafka. Bugs: KAFKA-1907