Re: Review Request 33731: Second Attempt to Fix KAFKA-2160

2015-05-13 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33731/#review83707 --- Pool is meant to be a simple, general purpose and very thin wrapper

Re: Review Request 33731: Second Attempt to Fix KAFKA-2160

2015-05-13 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33731/#review83694 --- Thanks for the patch. A few comments. 1. The changes in Pool are pr

Re: Review Request 33731: Second Attempt to Fix KAFKA-2160

2015-05-07 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33731/#review82911 --- I'm guessing the answer is yes, but is it too much of a performance

Re: Review Request 33731: Second Attempt to Fix KAFKA-2160

2015-05-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33731/ --- (Updated May 6, 2015, 11:31 p.m.) Review request for kafka. Summary (updated)