Re: Review Request 32440: Patch for KAFKA-2043

2015-03-25 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32440/#review77787 --- Ship it! - Mayuresh Gharat On March 25, 2015, 6:29 p.m., Grant He

Re: Review Request 32440: Patch for KAFKA-2043

2015-03-25 Thread Grant Henke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32440/ --- (Updated March 25, 2015, 6:29 p.m.) Review request for kafka. Bugs: KAFKA-204

Re: Review Request 32440: Patch for KAFKA-2043

2015-03-24 Thread Mayuresh Gharat
> On March 24, 2015, 5 p.m., Mayuresh Gharat wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 134 > > > > > > Since its a Producer level config, is this change needed. We

Re: Review Request 32440: Patch for KAFKA-2043

2015-03-24 Thread Grant Henke
> On March 24, 2015, 5 p.m., Mayuresh Gharat wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 134 > > > > > > Since its a Producer level config, is this change needed. We

Re: Review Request 32440: Patch for KAFKA-2043

2015-03-24 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32440/#review77593 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc