Re: Review Request 31816: Fix for KAFKA-527

2015-03-25 Thread Guozhang Wang
> On March 21, 2015, 1:42 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, lines 241-243 > > > > > > In the normal path, this should only happen when reading the offset. So > > we

Re: Review Request 31816: Fix for KAFKA-527

2015-03-25 Thread Guozhang Wang
> On March 21, 2015, 1:42 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, line 208 > > > > > > Can we just use wrapperMessage directly? I think we can, as we are just accessing i

Re: Review Request 31816: Fix for KAFKA-527

2015-03-20 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31816/#review77328 --- Thanks for the patch. A few comments below. core/src/main/scala/ka