Re: Review Request 29091: Patch for KAFKA-1646

2015-04-14 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated April 14, 2015, 10:46 a.m.) Review request for kafka. Changes --

Re: Review Request 29091: Patch for KAFKA-1646

2015-04-14 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated April 14, 2015, 10:44 a.m.) Review request for kafka. Summary (updat

Re: Review Request 29091: Patch for KAFKA-1646

2014-12-16 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/#review65216 --- Ship it! Overall it looks good to me. - Sriharsha Chintalapani O

Re: Review Request 29091: Patch for KAFKA-1646

2014-12-16 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated Dec. 16, 2014, 8:30 a.m.) Review request for kafka. Bugs: KAFKA-1646

Re: Review Request 29091: Patch for KAFKA-1646

2014-12-16 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated Dec. 16, 2014, 8:22 a.m.) Review request for kafka. Bugs: KAFKA-1646

Re: Review Request 29091: Patch for KAFKA-1646

2014-12-16 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated Dec. 16, 2014, 8:18 a.m.) Review request for kafka. Bugs: KAFKA-1646

Re: Review Request 29091: Patch for KAFKA-1646

2014-12-16 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated Dec. 16, 2014, 8:13 a.m.) Review request for kafka. Bugs: KAFKA-1646