Re: Review Request 24676: Rebase KAFKA-1583

2014-10-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review57235 --- Very nicely done. These are all minor comments - all but one concer

Re: Review Request 24676: Rebase KAFKA-1583

2014-10-17 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review57178 --- Thanks for the patch. +1 after addressing a couple of more minor com

Re: Review Request 24676: Rebase KAFKA-1583

2014-10-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Oct. 17, 2014, 4:56 p.m.) Review request for kafka. Summary (updated

Re: Review Request 24676: Rebase KAFKA-1583

2014-10-16 Thread Guozhang Wang
> On Oct. 16, 2014, 1:29 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 167 > > > > > > Should "replica manager" be "offset manager"? This is "replica manager" actually, when it tries

Re: Review Request 24676: Rebase KAFKA-1583

2014-10-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review56843 --- Thanks for the patch. Looks good to me. I only have some minor comme

Re: Review Request 24676: Rebase KAFKA-1583

2014-10-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Oct. 14, 2014, 2:42 a.m.) Review request for kafka. Summary (updated