Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/ --- (Updated Aug. 13, 2014, 6:24 p.m.) Review request for kafka. Bugs: KAFKA-1567

Re: Review Request 24196: Patch for KAFKA-1567

> On Aug. 13, 2014, 4:51 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala, line 163 > > > > > > This trace message is going to be a bit hard to understand. It's not > > clear what tho

Re: Review Request 24196: Patch for KAFKA-1567

> On Aug. 13, 2014, 4:51 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.scala, > > lines 60-61 > > > > > > Should we rename it to removeConsumerFetchRequestAndResponseStats()?

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review50462 --- core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.sca

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/ --- (Updated Aug. 13, 2014, 3:26 p.m.) Review request for kafka. Bugs: KAFKA-1567

Re: Review Request 24196: Patch for KAFKA-1567

> On Aug. 13, 2014, 4:28 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.scala, > > lines 61-68 > > > > > > Do we need to do the pattern matching here? Can we just remove based

Re: Review Request 24196: Patch for KAFKA-1567

> On Aug. 13, 2014, 4:28 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.scala, > > lines 61-68 > > > > > > Do we need to do the pattern matching here? Can we just remove based

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review50401 --- core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.sca

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/ --- (Updated Aug. 12, 2014, 10:20 p.m.) Review request for kafka. Bugs: KAFKA-156

Re: Review Request 24196: Patch for KAFKA-1567

> On Aug. 12, 2014, 3:43 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala, lines 119-120 > > > > > > Actually, I am not sure why DroppedMessagesPerSec is included in > > MessagesPerSe

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review50328 --- core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/ --- (Updated Aug. 11, 2014, 10:55 p.m.) Review request for kafka. Bugs: KAFKA-156

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review50125 --- core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/ --- (Updated Aug. 9, 2014, 1:44 a.m.) Review request for kafka. Bugs: KAFKA-1567

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review50036 --- Thanks for the patch. A few comments below. core/src/main/scala/ka

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/ --- (Updated Aug. 7, 2014, 9:26 p.m.) Review request for kafka. Bugs: KAFKA-1567

Re: Review Request 24196: Patch for KAFKA-1567

> On Aug. 1, 2014, 11:33 p.m., Guozhang Wang wrote: > > To be more precisely, in the old clients we have four stats classes: > > > > 1. ProducerTopicStats > > 2. ProducerRequestStats > > 3. ProducerStats > > 4. FetchRequestAndResponseStats > > 5. ConsumerTopicStats > > > > Among them: > > > >

Re: Review Request 24196: Patch for KAFKA-1567

> On Aug. 1, 2014, 11:33 p.m., Guozhang Wang wrote: > > To be more precisely, in the old clients we have four stats classes: > > > > 1. ProducerTopicStats > > 2. ProducerRequestStats > > 3. ProducerStats > > 4. FetchRequestAndResponseStats > > 5. ConsumerTopicStats > > > > Among them: > > > >

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review49401 --- To be more precisely, in the old clients we have four stats classes:

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review49385 --- core/src/main/scala/kafka/consumer/ConsumerIterator.scala