Re: Review Request 23767: Fix KAFKA-1430

2014-08-05 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/ --- (Updated Aug. 5, 2014, 9:54 p.m.) Review request for kafka. Bugs: KAFKA-1430

Re: Review Request 23767: Fix KAFKA-1430

2014-08-01 Thread Guozhang Wang
> On Aug. 1, 2014, 5:08 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/api/FetchResponse.scala, lines 28-29 > > > > > > Since we expose simple consumer as part of the api, this renaming is > > actually an api chang

Re: Review Request 23767: Fix KAFKA-1430

2014-08-01 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/#review49317 --- core/src/main/scala/kafka/server/DelayedFetch.scala

Re: Review Request 23767: Fix KAFKA-1430

2014-07-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/ --- (Updated July 31, 2014, 10:04 p.m.) Review request for kafka. Bugs: KAFKA-143

Re: Review Request 23767: Fix KAFKA-1430

2014-07-31 Thread Guozhang Wang
> On July 22, 2014, 5:02 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/cluster/Partition.scala, lines 120-130 > > > > > > We may not be able to remove the readlock here. The issue is that this > > method accesses

Re: Review Request 23767: Fix KAFKA-1430

2014-07-31 Thread Guozhang Wang
> On July 31, 2014, 4:40 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/api/FetchResponse.scala, lines 28-29 > > > > > > Do we want to rename this? There are lots of PartitionData and this one > > is specific to Fe

Re: Review Request 23767: Fix KAFKA-1430

2014-07-31 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/#review48944 --- core/src/main/scala/kafka/api/FetchResponse.scala

Re: Review Request 23767: Fix KAFKA-1430

2014-07-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/ --- (Updated July 28, 2014, 6:30 p.m.) Review request for kafka. Bugs: KAFKA-1430

Re: Review Request 23767: Fix KAFKA-1430

2014-07-26 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/#review48809 --- All new classes such as ProducerRequestPurgatory and FetchRequestPur

Re: Review Request 23767: Fix KAFKA-1430

2014-07-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/ --- (Updated July 25, 2014, 4:52 p.m.) Review request for kafka. Bugs: KAFKA-1430

Re: Review Request 23767: Fix KAFKA-1430

2014-07-25 Thread Guozhang Wang
> On July 22, 2014, 5:02 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/cluster/Partition.scala, lines 120-130 > > > > > > We may not be able to remove the readlock here. The issue is that this > > method accesses

Re: Review Request 23767: Fix KAFKA-1430

2014-07-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/#review48283 --- Thanks for the patch. There are some unused imports. Detailed commen

Re: Review Request 23767: Fix KAFKA-1430

2014-07-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/ --- (Updated July 21, 2014, 7:53 p.m.) Review request for kafka. Bugs: KAFKA-1430