Re: Review Request 22874: Fix KAFKA-1498

2014-07-01 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22874/ --- (Updated July 1, 2014, 6:12 p.m.) Review request for kafka. Bugs: KAFKA-1498

Re: Review Request 22874: Fix KAFKA-1498

2014-07-01 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22874/#review47100 --- Ship it! - Jay Kreps On June 30, 2014, 10:47 p.m., Guozhang Wang

Re: Review Request 22874: Fix KAFKA-1498

2014-07-01 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22874/#review47075 --- Could we add a record-size-avg metric in Sender? clients/src/main/

Re: Review Request 22874: Fix KAFKA-1498

2014-06-30 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22874/ --- (Updated June 30, 2014, 10:47 p.m.) Review request for kafka. Bugs: KAFKA-149

Re: Review Request 22874: Fix KAFKA-1498

2014-06-30 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22874/#review47007 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 22874: Fix KAFKA-1498

2014-06-30 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22874/ --- (Updated June 30, 2014, 5:47 p.m.) Review request for kafka. Bugs: KAFKA-1498

Re: Review Request 22874: Fix KAFKA-1498

2014-06-26 Thread Guozhang Wang
> On June 26, 2014, 4:57 a.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > line 76 > > > > > > I don't understand this parameter. Explained above.

Re: Review Request 22874: Fix KAFKA-1498

2014-06-25 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22874/#review46715 --- This is good. I have a couple of questions about the logic around de

Re: Review Request 22874: Fix KAFKA-1498

2014-06-25 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22874/ --- (Updated June 25, 2014, 11:44 p.m.) Review request for kafka. Bugs: KAFKA-149

Re: Review Request 22874: Fix KAFKA-1498

2014-06-24 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22874/#review46543 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 22874: Fix KAFKA-1498

2014-06-24 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22874/#review46540 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 22874: Fix KAFKA-1498

2014-06-24 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22874/#review46536 --- clients/src/main/java/org/apache/kafka/clients/NetworkClient.java <