Re: Review Request 18774: Patch for KAFKA-1240

> On March 8, 2014, 12:48 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/utils/Utils.scala, line 545 > > > > > > Since this logging entry is from the Utils we will not know the id of > > the producer either

Re: Review Request 18774: Patch for KAFKA-1240

> On March 7, 2014, 6:48 p.m., Jay Kreps wrote: > > core/src/main/scala/kafka/utils/Utils.scala, line 545 > > > > > > This cannot go in utils and utils cannot depend on the producer (for > > obvious reasons). This is

Re: Review Request 18774: Patch for KAFKA-1240

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18774/#review36588 --- core/src/main/scala/kafka/utils/Utils.scala

Re: Review Request 18774: Patch for KAFKA-1240

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18774/#review36554 --- core/src/main/scala/kafka/utils/Utils.scala

Re: Review Request 18774: Patch for KAFKA-1240

> On March 7, 2014, 1:58 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/utils/Utils.scala, line 560 > > > > > > Can we change this to error("Error... exception", e). > > e.getMessage is not terribly usef

Re: Review Request 18774: Patch for KAFKA-1240

> On March 7, 2014, 1:58 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/utils/Utils.scala, line 560 > > > > > > Can we change this to error("Error... exception", e). > > e.getMessage is not terribly usef

Re: Review Request 18774: Patch for KAFKA-1240

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18774/#review36473 --- Ship it! core/src/main/scala/kafka/utils/Utils.scala

Re: Review Request 18774: Patch for KAFKA-1240

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18774/ --- (Updated March 7, 2014, 1:42 a.m.) Review request for kafka. Bugs: KAFKA-1240

Re: Review Request 18774: Patch for KAFKA-1240

> On March 5, 2014, 6:33 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala, line 159 > > > > > > I had initially added multiple producer support to the mirror maker > > until

Re: Review Request 18774: Patch for KAFKA-1240

> On March 5, 2014, 6:33 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala, line 159 > > > > > > I had initially added multiple producer support to the mirror maker > > until

Re: Review Request 18774: Patch for KAFKA-1240

> On March 5, 2014, 6:33 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala, line 159 > > > > > > I had initially added multiple producer support to the mirror maker > > until

Re: Review Request 18774: Patch for KAFKA-1240

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18774/ --- (Updated March 6, 2014, 5:36 p.m.) Review request for kafka. Bugs: KAFKA-1240

Re: Review Request 18774: Patch for KAFKA-1240

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18774/ --- (Updated March 6, 2014, 5:24 p.m.) Review request for kafka. Bugs: KAFKA-1240

Re: Review Request 18774: Patch for KAFKA-1240

> On March 5, 2014, 6:33 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala, line 159 > > > > > > I had initially added multiple producer support to the mirror maker > > until

Re: Review Request 18774: Patch for KAFKA-1240

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18774/#review36245 --- core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala