Re: Review Request 18199: Patch for KAFKA-1252

2014-02-19 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18199/#review34981 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 18199: Patch for KAFKA-1252

2014-02-18 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18199/ --- (Updated Feb. 19, 2014, 1:15 a.m.) Review request for kafka. Bugs: KAFKA-1252

Re: Review Request 18199: Patch for KAFKA-1252

2014-02-18 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18199/#review34795 --- Ship it! Minor comments below clients/src/main/java/org/apache/ka

Re: Review Request 18199: Patch for KAFKA-1252

2014-02-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18199/#review34705 --- Ship it! +1. Just some minor comments below. clients/src/main/jav