Re: Re: [DISCUSS] KIP-213 Support non-key joining in KTable

2017-11-01 Thread Damian Guy
Hi Jan, Thanks for the KIP! In both alternatives the API will need to use the `Joined` class rather than than passing in `Serde`s. Also, as with all other joins etc, there probably should be an overload that doesn't require any `Serdes`. It isn't clear to me what `joinPrefixFaker` is doing? In th

Re: Re: [DISCUSS] KIP-213 Support non-key joining in KTable

2017-10-27 Thread Ted Yu
I think if you explain what A and B are in the beginning, it makes sense to use them since readers would know who they reference. Cheers On Thu, Oct 26, 2017 at 11:04 PM, Jan Filipiak wrote: > > > Thanks for the remarks. hope I didn't miss any. > Not even sure if it makes sense to introduce A a