Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2018-04-07 Thread Ted Yu
Can you start another thread with [VOTE] in the subject ? Original message From: 东方甲乙 <254479...@qq.com> Date: 4/7/18 6:10 AM (GMT-08:00) To: dev Subject: Re: [DISCUSS] KIP-148: Add a  connect timeout for client Hi all, Do you have further concerns or questions about this K

Re?? Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-29 Thread ????????
David -- -- ??: "Rajini Sivaram";; : 2017??5??23??(??) 11:57 ??: ""<254479...@qq.com>; ????: "dev"; ????: Re: Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client Hi David, The only iss

Re: Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread Rajini Sivaram
dler these different cases. > > Thanks, > David > > -- 原始邮件 -- > *发件人:* "Rajini Sivaram" ; > *发送时间:* 2017年5月23日(星期二) 19:27 > *收件人:* "dev" ; > *主题:* Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client > > > G

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread Rajini Sivaram
Guozhang, At the moment we don't have a connect timeout. And the behaviour suggested in the KIP is useful to address this. We do however have a request.timeout.ms. This is the amount of time it would take to detect a crashed broker if the broker crashed after a connection was established. Unfortu

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Simon Souter
The following tickets are probably relevant to this KIP: https://issues.apache.org/jira/browse/KAFKA-3457 https://issues.apache.org/jira/browse/KAFKA-1894 https://issues.apache.org/jira/browse/KAFKA-3834 On 22 May 2017 at 16:30, Rajini Sivaram wrote: > Ismael, > > Yes, agree. My concern was tha

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Guozhang Wang
Could you refresh me what's the issue of consumer that caused us to set the default values of connect.timeout to 5 min? Guozhang On Mon, May 22, 2017 at 8:35 AM, Ismael Juma wrote: > Yes, I agree that one config would be better. Just a bit more work to > achieve the desired effect for the Cons

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Ismael Juma
Yes, I agree that one config would be better. Just a bit more work to achieve the desired effect for the Consumer. Ismael On Mon, May 22, 2017 at 4:30 PM, Rajini Sivaram wrote: > Ismael, > > Yes, agree. My concern was that a connection can be shutdown uncleanly at > any time. If a client is in

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Rajini Sivaram
Ismael, Yes, agree. My concern was that a connection can be shutdown uncleanly at any time. If a client is in the middle of a request, then it times out after min(request.timeout.ms, tcp-timeout). If we add another config option connect.timeout.ms, then we will sometimes wait for min(connect.timeo

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Ismael Juma
Rajini, For this to have the desired effect, we'd probably need to lower the default request.timeout.ms for the consumer and fix the underlying reason why it is a little over 5 minutes at the moment. Ismael On Mon, May 22, 2017 at 4:15 PM, Rajini Sivaram wrote: > Hi David, > > Sorry, what I me

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Rajini Sivaram
Hi David, Sorry, what I meant was: Can you reuse the existing configuration option request.timeout,ms , instead of adding a new config and add the behaviour that you have proposed in the KIP for the connection phase using this timeout? I think the timeout for connection is useful. I am not sure we