Re: RE: RE: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-24 Thread Guozhang Wang
Not sure if I fully understand your question, but here's my understanding: In LogCleaner we call: "val records = MemoryRecords.readableRecords(readBuffer)" Which returns a MemoryRecords object, and then call filterInto with a given customized RecordFilter that instantiates "checkBatchRetention(ba

Re: RE: RE: [DISCUSS] KIP-280: Enhanced log compaction

2018-04-24 Thread Luís Cabral
Hi Guozhang, As much as I would like to move on from this topic, I've now tried to implement it into the pull request, and could not find a viable way to store a variable size byte array into the current concept of the log cleaner (with long the current approach just always considers it to be