Re: Question about concurrency during Log config change

2015-03-16 Thread Andrii Biletskyi
Jay, Thanks for quick response. Yes, this might be not that harmful for users, I'm not sure about that. But it definitely looks like data race. Your solution is simple and should work, hard to tell promptly when it's about concurrency. Initially I was looking through this code to understand wheth

Re: Question about concurrency during Log config change

2015-03-16 Thread Jay Kreps
You are correct. Each read will be a valid value but there is no guarantee that subsequent reads will read from the same config. I don't think that is a problem, do you? If we want to strengthen the guarantee we can grab the config once in the method val config = log.config and then do however m