Re: Protocol Documentation WIP

2016-03-09 Thread Grant Henke
FYI. I have updated the pull request here: https://github.com/apache/kafka/pull/970 On Wed, Mar 9, 2016 at 10:18 PM, Guozhang Wang wrote: > Hey Ewen, > > For "its own page" which location are you specifically thinking about? > > Guozhang > > On Wed, Mar 9, 2016 at 6:48 AM, Grant Henke wrote:

Re: Protocol Documentation WIP

2016-03-09 Thread Guozhang Wang
Hey Ewen, For "its own page" which location are you specifically thinking about? Guozhang On Wed, Mar 9, 2016 at 6:48 AM, Grant Henke wrote: > Ewen, > > I am okay with that. I agree something is better than nothing. I can touch > up the patch today and open some jiras to track future work. > >

Re: Protocol Documentation WIP

2016-03-09 Thread Grant Henke
Ewen, I am okay with that. I agree something is better than nothing. I can touch up the patch today and open some jiras to track future work. Thanks, Grant On Wed, Mar 9, 2016 at 1:50 AM, Ewen Cheslack-Postava wrote: > Agreed w/ Jay's comment on the PR that this is a great idea. What if we > i

Re: Protocol Documentation WIP

2016-03-08 Thread Ewen Cheslack-Postava
Agreed w/ Jay's comment on the PR that this is a great idea. What if we included this as is, but instead of putting it all on the docs page we put it on its own page? This: 1. Gets us something useful wrt protocol docs immediately. As you point out, this is already useful to a bunch of people. 2.