Re: PR review requests

Hi Lorcan, Thanks for your interest in Apache Kafka! I added committers as reviewers to your PRs. I replied to your comment on the ticket. Best, Bruno On 17.03.25 17:38, lorcan james wrote: Hi, I am a new contributor to Apache Kafka from the community and have submitted some PRs. I read it'

Re: PR review request for KIP-1032

> There should be plenty of time, I just wanted to make sure it doesn't get forgotten for the 4.0 release. We can not forget about the CVEs, so I'll never forget your PR that is trying to save us from Jetty CVE hell! Best, Chia-Ping Christopher Shannon 於 2024年10月17日 週四 上午2:15寫道： > Hi Chia-Ping

Re: PR review request for KIP-1032

Hi Chia-Ping, Ok sounds good, thanks. Some of these changes are a bit dependent on each other due to the JDK 17 change so no problem if needing to resolve KAFKA-16096 first. There should be plenty of time, I just wanted to make sure it doesn't get forgotten for the 4.0 release. Chris On Wed, Oct

Re: PR review request for KIP-1032

hi Chris, I'd like to review your PR, but we might need to resolve KAFKA-16096 first. Since your PR is a good starting point for KAFKA-16096, we can address it quickly. Best, Chia-Ping Christopher Shannon 於 2024年10月16日 週三 下午11:00寫道： > Can so

Re: PR Review

Hi, Can anyone help in reviewing the below pr please..? Thanks, Nandini A. On Mon, Sep 5, 2022 at 11:32 AM Nandini Anagondi wrote: > Hi, > > Can you help me in reviewing this pr please.? > https://github.com/apache/kafka/pull/11516/files. > > Thanks, > Nandini A. > >

Re: PR review

Hello Colin, I appreciate the time for reviewing this PR. I have now incorporated your (and Matthias's) comments and the PR has been resubmitted. Please let me know if there is more that we need to change. Thanks again, On Mon, 8 Jul 2019 at 23:50, Colin McCabe wrote: > Hi M. Manna, > > I left

Re: PR review

Hi M. Manna, I left a review. Take a look. Sorry for the delays. best, Colin On Mon, Jul 8, 2019, at 14:38, M. Manna wrote: > Hello, > > A few requests have been sent already. Could this please be reviewed ? Our > business implementation is holding due to this change. > > > > On Thu, 4 Ju

Re: PR review

Hello, A few requests have been sent already. Could this please be reviewed ? Our business implementation is holding due to this change. On Thu, 4 Jul 2019 at 13:33, M. Manna wrote: > https://github.com/apache/kafka/pull/6771 > > Could this be reviewed please ? > > On Wed, 3 Jul 2019 at 11:35

Re: PR review

https://github.com/apache/kafka/pull/6771 Could this be reviewed please ? On Wed, 3 Jul 2019 at 11:35, M. Manna wrote: > https://github.com/apache/kafka/pull/6771 > > Bouncing both users and dev to get some activity going. We are waiting for > a while to get this KIP pr merged. > > Could someon

Re: PR review

https://github.com/apache/kafka/pull/6771 Bouncing both users and dev to get some activity going. We are waiting for a while to get this KIP pr merged. Could someone please review? Thanks, On Sun, 30 Jun 2019 at 08:59, M. Manna wrote: > https://github.com/apache/kafka/pull/6771 > > Hello, > >

Re: PR review

I have updated it with my comments - @mjsax could you kindly comment I stopped watching the issue since it sends all updates to all issues to my inbox :) Thanks, On Sat, 22 Jun 2019 at 10:48, M. Manna wrote: > Thanks Matthias. Moved to dev DL now. > > I saw your comment on the PR regarding impo

Re: PR review

Thanks Matthias. Moved to dev DL now. I saw your comment on the PR regarding imports. I’ll fix those and resubmit. Thanks, On Sat, 22 Jun 2019 at 01:22, Matthias J. Sax wrote: > I would recommend to move this discussion to the dev list. > > -Matthias > > On 6/20/19 7:42 PM, M. Manna wrote: > >