Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient

2017-09-07 Thread Viktor Somogyi
tp://paolopatierno.wordpress.com/> > > > > From: isma...@gmail.com on behalf of Ismael Juma < > ism...@juma.me.uk> > Sent: Thursday, September 7, 2017 10:56 AM > To: dev@kafka.apache.org > Subject: Re: KAFKA-5723: Refactor BrokerAp

Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient

2017-09-07 Thread Paolo Patierno
no.wordpress.com/> > > > > From: isma...@gmail.com on behalf of Ismael Juma < > ism...@juma.me.uk> > Sent: Thursday, September 7, 2017 10:19 AM > To: dev@kafka.apache.org > Subject: Re: KAFKA-5723: Refactor BrokerApiVersionsComman

Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient

2017-09-07 Thread Ismael Juma
> From: isma...@gmail.com on behalf of Ismael Juma < > ism...@juma.me.uk> > Sent: Thursday, September 7, 2017 10:19 AM > To: dev@kafka.apache.org > Subject: Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new > AdminClient >

Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient

2017-09-07 Thread Paolo Patierno
behalf of Ismael Juma Sent: Thursday, September 7, 2017 10:19 AM To: dev@kafka.apache.org Subject: Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient I would also add that it would be easier to review if there were smaller PRs than one big PR. So, it may be worth think

Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient

2017-09-07 Thread Paolo Patierno
ache.org Subject: Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient I can't speak for the committers, but there's nothing to stop you submitting PRs against each others branches. It just needs you to agree which of you will host the integration branch. This would

Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient

2017-09-07 Thread Ismael Juma
itter : @ppatierno<http://twitter.com/ppatierno> > > Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno> > > Blog : DevExperience<http://paolopatierno.wordpress.com/> > > > > > > ________________ > > From: Paolo Patierno

Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient

2017-09-07 Thread Tom Bentley
atierno> > Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno> > Blog : DevExperience<http://paolopatierno.wordpress.com/> > > > > From: Paolo Patierno > Sent: Thursday, August 17, 2017 3:18 PM > To: dev@kafka.apache.or

Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient

2017-09-07 Thread Paolo Patierno
: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient As I started on working to develop the TopicCommand tool in Java (with this PR<https://github.com/apache/kafka/pull/3514>), Andrey is working on another one and he started to use some of my classes (mostly related to hand

Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient

2017-08-17 Thread Paolo Patierno
As I started on working to develop the TopicCommand tool in Java (with this PR), Andrey is working on another one and he started to use some of my classes (mostly related to handling command line arguments) just with copy/paste/modify so duplicating the