Re: KAFKA-1194

2018-09-03 Thread Stephane Maarek
Hi Manna If you check the first email in this thread I was telling I already tested the fix by Dong and that it unfortunately didn't work. I've been building from trunk. I've instead opened a PR based on various other people's fixes and it passed Jenkins and also fixes the windows issues encounte

Re: KAFKA-1194

2018-09-03 Thread Ismael Juma
KAFKA-7278 doesn't fix the Windows issues. Ismael On Mon, 3 Sep 2018, 02:42 M. Manna, wrote: > Hi Stephan, > > https://jira.apache.org/jira/browse/KAFKA-7278 > > This might (according to Dong) be a better fix for the issue. Could you > kindly apply to patch to your kafka (assuming that your ver

Re: KAFKA-1194

2018-09-03 Thread M. Manna
Hi Stephan, https://jira.apache.org/jira/browse/KAFKA-7278 This might (according to Dong) be a better fix for the issue. Could you kindly apply to patch to your kafka (assuming that your version is reasonably close to the latest), and see if that helps? Regards, On Mon, 3 Sep 2018 at 02:27, Ism

Re: KAFKA-1194

2018-09-03 Thread Stephane Maarek
Sorry for the double email. I've compiled the fixes made by the other PR and it fixes the Windows problem: https://github.com/apache/kafka/pull/5603 It triggers a few errors in the unit tests, which is probably due to the order changes of which files are deleted. Let's continue the discussion ther

Re: KAFKA-1194

2018-09-02 Thread Stephane Maarek
Hi Ismael, thanks for having a look! https://github.com/apache/kafka/pull/4947/files does not fix it for me. But this one does: https://github.com/apache/kafka/pull/4431 It produces the following log: https://pastebin.com/NHeAcc6v As you can see the folders do get renamed, it gives the user a few

Re: KAFKA-1194

2018-09-02 Thread Ismael Juma
Hi Stephane, Does https://github.com/apache/kafka/pull/4947/files fix it for you? Ismael On Sun, Sep 2, 2018 at 11:25 AM Stephane Maarek < steph...@simplemachines.com.au> wrote: > Hi, > > I've seen Dong has done some work on > https://issues.apache.org/jira/browse/KAFKA-7278 which is said from