Re: First time patch submitter advice

Thanks Bruno > On 19 Jun 2020, at 6:48 pm, Bruno Cadonna wrote: > > I meant "Hi Michael" not Luke. > Sorry Michael and Luke. > > Best, > Bruno > > On Fri, Jun 19, 2020 at 10:47 AM Bruno Cadonna wrote: >> >> Hi Luke, >> >> The guide is a bit outdated. Thank you for pointing it out. I updated

Re: First time patch submitter advice

Hope the committer runs the tests locally. If the Jenkins tests don’t work, that is a back and forth between the team and committer. For the most part if tested locally, the Kafka team is responsible to take the PR forward from there on. I really don’t understand the issue here On Sun, Jun 14, 20

Re: First time patch submitter advice

I meant "Hi Michael" not Luke. Sorry Michael and Luke. Best, Bruno On Fri, Jun 19, 2020 at 10:47 AM Bruno Cadonna wrote: > > Hi Luke, > > The guide is a bit outdated. Thank you for pointing it out. I updated the > guide. > > As Gwen stated above: > > > Unfortunately, you need to get a committer

Re: First time patch submitter advice

Hi Luke, The guide is a bit outdated. Thank you for pointing it out. I updated the guide. As Gwen stated above: > Unfortunately, you need to get a committer to approve running the tests. So, yes a committer has to comment on the PR. Best, Bruno On Fri, Jun 19, 2020 at 1:28 AM Michael Carter

Re: First time patch submitter advice

Hi Gwen and Luke, Sorry, I’ve probably misunderstood something again. Since KAFKA-10155 and KAFKA-10147 have now been resolved, I merged the trunk back into my branch and added to comment “retest this please” to my pull request (https://github.com/apache/kafka/pull/8844

Re: First time patch submitter advice

Great, thanks Luke. I’ve undone the patch and added that comment. Cheers, Michael > On 15 Jun 2020, at 6:07 pm, Luke Chen wrote: > > Hi Michael, > The failed unit test has already handled here: > https://issues.apache.org/jira/browse/KAFKA-10155 > https://issues.apache.org/jira/browse/KAFKA-101

Re: First time patch submitter advice

Hi Michael, The failed unit test has already handled here: https://issues.apache.org/jira/browse/KAFKA-10155 https://issues.apache.org/jira/browse/KAFKA-10147 So, maybe you can ignore the test errors and mention the issue number in PR. Thanks. Luke On Mon, Jun 15, 2020 at 3:23 PM Michael Carter

Re: First time patch submitter advice

Thanks for the response Gwen, that clarifies things for me. Regarding the unit test (ReassignPartitionsUnitTest. testModifyBrokerThrottles), it appears to fail quite reliably on trunk as well (at least on my machine). It looks to me like a new override to MockAdminClient.describeConfigs(Collec

Re: First time patch submitter advice

Hi, 1. Unfortunately, you need to get a committer to approve running the tests. I just gave the green-light on your PR. 2. You can hope that committers will see your PR, but sometimes things get lost. If you know someone who is familiar with that area of the code, it is a good idea to ping them. 3