Re: CRC patch

2012-12-14 Thread David Arthur
+1 from me, though I did submit the patch On 12/13/12 1:40 AM, Joe Stein wrote: +1 on the code change looks alright, I prefer using the java version in this case only because we are using an implementation from another project and its a drop in ... no reason to change things without good reason,

Re: CRC patch

2012-12-12 Thread Joe Stein
+1 on the code change looks alright, I prefer using the java version in this case only because we are using an implementation from another project and its a drop in ... no reason to change things without good reason, yup. On Wed, Dec 12, 2012 at 11:55 PM, Jay Kreps wrote: > This patch is pretty