Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-12-01 Thread Ismael Juma
Thanks for explaining your reasoning, Rajini. I do agree with all of it and that's why I voted +1. :) The reason for my comment was to highlight some of the areas that can be improved in case someone has the time and interest. The Kerberos situation is the obvious one, but one could also imagine f

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-11-29 Thread Neha Narkhede
Super useful, thanks Rajini. +1 On Tue, Nov 29, 2016 at 8:11 AM Rajini Sivaram wrote: > I have added this to the KIP. > > Thanks, > > Rajini > > On Tue, Nov 29, 2016 at 12:14 PM, Ismael Juma wrote: > > > One more thing: we are using the PASSWORD config type to avoid exposing > > passwords. This

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-11-29 Thread Rajini Sivaram
I have added this to the KIP. Thanks, Rajini On Tue, Nov 29, 2016 at 12:14 PM, Ismael Juma wrote: > One more thing: we are using the PASSWORD config type to avoid exposing > passwords. This will also make it harder to debug issues with the JAAS > config though, it would be good to mention this

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-11-29 Thread Ismael Juma
One more thing: we are using the PASSWORD config type to avoid exposing passwords. This will also make it harder to debug issues with the JAAS config though, it would be good to mention this drawback in the KIP. Ismael On Mon, Nov 28, 2016 at 1:00 PM, Ismael Juma wrote: > I'm very late to this,

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-11-28 Thread Rajini Sivaram
Ismael, Thank you for reviewing the KIP. I do agree that JAAS config format is not ideal. But I wanted to solve the generic configuration issue (need for physical file, single static config) for any SASL mechanism in an extensible, future-proof way. And that requires the ability to configure all t

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-11-28 Thread Ismael Juma
I'm very late to this, but better late than never, I guess. I am +1 on this because it improves on the status quo, satisfies a real need and is simple to implement. Having said that, I'd also like to state that it's a bit of a shame that we are doubling down on the JAAS config format. It is a pecu

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-11-01 Thread Rajini Sivaram
KIP-85 vote has passed with 4 binding (Harsha, Gwen, Jason, Jun) and 4 non-binding (Mickael, Jim, Edo, me) votes. Thank you all for your votes and comments. I will update the KIP page and rebase the PR. Many thanks, Rajini On Mon, Oct 31, 2016 at 11:29 AM, Edoardo Comar wrote: > +1 great KI

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-10-31 Thread Edoardo Comar
+1 great KIP -- Edoardo Comar IBM MessageHub eco...@uk.ibm.com IBM UK Ltd, Hursley Park, SO21 2JN IBM United Kingdom Limited Registered in England and Wales with number 741598 Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-10-30 Thread Jun Rao
Rajini, Thanks for the KIP. +1 Jun On Wed, Oct 26, 2016 at 8:26 AM, Rajini Sivaram < rajinisiva...@googlemail.com> wrote: > I would like to initiate the voting process for KIP-85: Dynamic JAAS > configuration for Kafka Clients: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-85%3A+Dyn

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-10-27 Thread Jason Gustafson
Thanks for the KIP! +1 On Wed, Oct 26, 2016 at 3:23 PM, Gwen Shapira wrote: > Woohoo! +1 (binding) > > On Wed, Oct 26, 2016 at 5:26 PM, Rajini Sivaram < > rajinisiva...@googlemail.com> wrote: > > > I would like to initiate the voting process for KIP-85: Dynamic JAAS > > configuration for Kafka C

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-10-26 Thread Gwen Shapira
Woohoo! +1 (binding) On Wed, Oct 26, 2016 at 5:26 PM, Rajini Sivaram < rajinisiva...@googlemail.com> wrote: > I would like to initiate the voting process for KIP-85: Dynamic JAAS > configuration for Kafka Clients: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-85%3A+Dynamic+JAAS+ > con

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-10-26 Thread Jim Jagielski
+1! > On Oct 26, 2016, at 11:26 AM, Rajini Sivaram > wrote: > > I would like to initiate the voting process for KIP-85: Dynamic JAAS > configuration for Kafka Clients: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-85%3A+Dynamic+JAAS+configuration+for+Kafka+clients > > This KIP ena

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-10-26 Thread Mickael Maison
+1 Great work Rajini. On Wed, Oct 26, 2016 at 5:29 PM, Harsha Chintalapani wrote: > Thanks for the KIP Rajini. This looks great. +1. > -Harsha > > On Wed, Oct 26, 2016 at 8:26 AM Rajini Sivaram > wrote: > >> I would like to initiate the voting process for KIP-85: Dynamic JAAS >> configuration fo

Re: [VOTE] KIP-85: Dynamic JAAS configuration for Kafka clients

2016-10-26 Thread Harsha Chintalapani
Thanks for the KIP Rajini. This looks great. +1. -Harsha On Wed, Oct 26, 2016 at 8:26 AM Rajini Sivaram wrote: > I would like to initiate the voting process for KIP-85: Dynamic JAAS > configuration for Kafka Clients: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-85%3A+Dynamic+JAAS+