HI all
The summary of the vote: *Total 6 +ve* with *+4 Binding*, +2 non-Binding.
I'll move the KIP to Accepted state.
Thanks
Maulin
On Tue, Mar 31, 2020 at 10:32 PM Maulin Vasavada
wrote:
> Thanks Rajini and Jun. I'll update the shouldBeRebuilt() docs on what
> happens to existing SSL Connecti
Thanks Rajini and Jun. I'll update the shouldBeRebuilt() docs on what
happens to existing SSL Connections.
Thanks everybody who participated in the discussion thread and voting
thread and spending the valuable time reviewing the KIP/PR. Could not have
done it without your support. Really appreciat
Hi, Rajini, Maulin,
1. Ok. Then we can keep the package name as it is.
2. Thanks for updating the javadoc for shouldBeRebuilt(). Could you also
clarify after the SslEngine is rebuilt, what happens to existing SSL
connections?
Thanks,
Jun
On Tue, Mar 31, 2020 at 2:07 AM Rajini Sivaram
wrote:
+1 (non-binding)
Thanks
Renuka M
On Tue, Mar 31, 2020 at 2:07 AM Rajini Sivaram
wrote:
> Hi Jun, Maulin,
>
> org.apache.kafka.common.security.ssl contains internal classes like
> SslFactory. org.apache.kafka.common.security.auth is a public package
> which contains all our current authenticat
Hi Jun, Maulin,
org.apache.kafka.common.security.ssl contains internal classes like
SslFactory. org.apache.kafka.common.security.auth is a public package
which contains all our current authentication-related classes. If we want
to move the new interface into an SSL-specific package, we should pe
+1 (binding).
Thanks for the KIP.
Thanks,
Manikumar
On Tue, Mar 31, 2020 at 11:24 AM Maulin Vasavada
wrote:
> Hi all,
>
> So far we got 3 Binding votes. I am planning to keep the voting phase open
> until Tuesday 10 PM Pacific Time which will be more than 72 hours from the
> first binding vote
Hi all,
So far we got 3 Binding votes. I am planning to keep the voting phase open
until Tuesday 10 PM Pacific Time which will be more than 72 hours from the
first binding vote on Thursday 12:36 PM Pacific Time.
Thanks
Maulin
On Mon, Mar 30, 2020 at 10:32 PM Maulin Vasavada
wrote:
> Hi all,
>
Hi all,
I updated the Javadoc in the KIP details and the actual SslEngineFactory
interface for shouldBeRebuilt(). For the first comment, probably I'll try
to address it tomorrow.
Thanks
Maulin
On Mon, Mar 30, 2020 at 7:44 PM Maulin Vasavada
wrote:
> Thanks Jun Rao for your vote and comments.
>
Thanks for putting the KIP together. This is going to help quite a bit in
customizing SSL.
+1 (binding).
Thanks,
Harsha
On Mon, Mar 30, 2020 at 7:44 PM Maulin Vasavada
wrote:
> Thanks Jun Rao for your vote and comments.
>
> For 1) Earlier it was the security.ssl package but after a review I ch
Thanks Jun Rao for your vote and comments.
For 1) Earlier it was the security.ssl package but after a review I changed
it to .auth since there are some public interfaces in that package. I am
open to move it under .ssl package.
For 2) Sure. Will document in Javadocs for the method.
Thanks
Maulin
Hi, Maulin,
Thanks for the KIP. +1 from me. Just a couple of minor comments below.
1. Should the package name of the new
interface SslEngineFactory be org.apache.kafka.common.security.ssl instead
of org.apache.kafka.common.security.auth?
2. Could you document when shouldBeRebuilt() will be called
^^^ bump ^^^ The vote is open for 2-3 days and gotten 1 Binding vote so
far, can you please vote so that we can try to move forward with changes?
On Thu, Mar 26, 2020 at 4:11 PM Zhou, Thomas
wrote:
> +1 (non-binding)
>
> Regards,
> Thomas
>
> On 3/26/20, 12:36 PM, "Rajini Sivaram" wrote:
>
>
+1 (non-binding)
Regards,
Thomas
On 3/26/20, 12:36 PM, "Rajini Sivaram" wrote:
+1 (binding)
Thanks for the KIP, Maulin!
Regards,
Rajini
On Thu, Mar 26, 2020 at 4:14 PM Maulin Vasavada
wrote:
> FYI - we have updated the KIP documentation also wit
+1 (binding)
Thanks for the KIP, Maulin!
Regards,
Rajini
On Thu, Mar 26, 2020 at 4:14 PM Maulin Vasavada
wrote:
> FYI - we have updated the KIP documentation also with appropriate code
> samples for interfaces and few important changes.
>
> Thanks
> Maulin
>
> On Wed, Mar 25, 2020 at 10:21 AM
FYI - we have updated the KIP documentation also with appropriate code
samples for interfaces and few important changes.
Thanks
Maulin
On Wed, Mar 25, 2020 at 10:21 AM Maulin Vasavada
wrote:
> bump
>
> On Wed, Mar 25, 2020 at 10:20 AM Maulin Vasavada <
> maulin.vasav...@gmail.com> wrote:
>
>> H
bump
On Wed, Mar 25, 2020 at 10:20 AM Maulin Vasavada
wrote:
> Hi all
>
> After much await on the approach conclusion we have a PR
> https://github.com/apache/kafka/pull/8338.
>
> Can you please provide your vote so that we can more this forward?
>
> Thanks
> Maulin
>
> On Sun, Jan 26, 2020 at 1
Hi all
After much await on the approach conclusion we have a PR
https://github.com/apache/kafka/pull/8338.
Can you please provide your vote so that we can more this forward?
Thanks
Maulin
On Sun, Jan 26, 2020 at 11:03 PM Maulin Vasavada
wrote:
> Hi all
>
> After a good discussion on the KIP a
17 matches
Mail list logo
