Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-06-27 Thread Stanislav Kozlovski
Hey there everybody, We're moving along. I wanted to come back with some updates we came up with while iterating on the PR: - Removed the ALL log level - all the rest log levels are quite standard but this is not that expected. Simpler is always better :) - We have changed the DescribeConfigs API

Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-06-12 Thread Stanislav Kozlovski
Hello, I finished work on an initial PR for this KIP, it is ready for review here - https://github.com/apache/kafka/pull/6903 During implementation, I noticed a couple of holes in the KIP and did the following changes: * add LogLevelConfig public class and a few more log levels (7 total - ALL, TR

Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-02-21 Thread Stanislav Kozlovski
Thanks for the interest everybody. This KIP has passed with 3 binding votes (Harsha, Gwen, Rajini) and 5 non-binding votes (Mickael, Jonathan, Dongjin, Satish, Andrew) On Thu, Feb 21, 2019 at 9:00 AM Satish Duggana wrote: > Thanks for the KIP > +1 (non-binding) > > On Thu, Feb 21, 2019 at 9:38

Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-02-21 Thread Satish Duggana
Thanks for the KIP +1 (non-binding) On Thu, Feb 21, 2019 at 9:38 AM Harsha wrote: > > +1 (binding). > > Thanks, > Harsha > > On Tue, Feb 19, 2019, at 7:53 AM, Andrew Schofield wrote: > > Thanks for the KIP. > > > > +1 (non-binding) > > > > On 18/02/2019, 12:48, "Stanislav Kozlovski" wrote: > >

Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-02-20 Thread Harsha
+1 (binding). Thanks, Harsha On Tue, Feb 19, 2019, at 7:53 AM, Andrew Schofield wrote: > Thanks for the KIP. > > +1 (non-binding) > > On 18/02/2019, 12:48, "Stanislav Kozlovski" wrote: > > Hey everybody, I'm starting a VOTE thread for KIP-412. This feature should > significantly impr

Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-02-19 Thread Andrew Schofield
Thanks for the KIP. +1 (non-binding) On 18/02/2019, 12:48, "Stanislav Kozlovski" wrote: Hey everybody, I'm starting a VOTE thread for KIP-412. This feature should significantly improve the flexibility and ease in debugging Kafka in run time KIP-412 - https://nam03.saf

Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-02-19 Thread Dongjin Lee
essage- > From: Gwen Shapira > Sent: 19 February 2019 04:57 > To: dev > Subject: Re: [VOTE] KIP-412: Extend Admin API to support dynamic > application log levels > > +1 > > On Mon, Feb 18, 2019, 3:48 AM Stanislav Kozlovski > wrote: > > > Hey everybody,

RE: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-02-19 Thread Skrzypek, Jonathan
+1 (non-binding) Jonathan Skrzypek -Original Message- From: Gwen Shapira Sent: 19 February 2019 04:57 To: dev Subject: Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels +1 On Mon, Feb 18, 2019, 3:48 AM Stanislav Kozlovski wrote: > Hey everybody,

Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-02-18 Thread Gwen Shapira
+1 On Mon, Feb 18, 2019, 3:48 AM Stanislav Kozlovski wrote: > Hey everybody, I'm starting a VOTE thread for KIP-412. This feature should > significantly improve the flexibility and ease in debugging Kafka in run > time > > KIP-412 - > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-412%3

Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-02-18 Thread Rajini Sivaram
Thanks for the KIP, Stanislav! +1 (binding) Regards, Rajini On Mon, Feb 18, 2019 at 1:54 PM Mickael Maison wrote: > +1 (non-binding) > We've used a tweaked JmxTool class to change log level for a while but > this is a significant improvement! > Thanks for the KIP > > On Mon, Feb 18, 2019 at

Re: [VOTE] KIP-412: Extend Admin API to support dynamic application log levels

2019-02-18 Thread Mickael Maison
+1 (non-binding) We've used a tweaked JmxTool class to change log level for a while but this is a significant improvement! Thanks for the KIP On Mon, Feb 18, 2019 at 11:48 AM Stanislav Kozlovski wrote: > > Hey everybody, I'm starting a VOTE thread for KIP-412. This feature should > significantly