Re: [VOTE] KIP-251: Allow timestamp manipulation in Processor API

2018-03-09 Thread Matthias J. Sax
+1 I am also closing this vote. The KIP is accepted with 3 binding votes (Damian, Guozhang, Matthias) and 2 non-binding votes (Ted, Bill) Thanks for your comments and votes! -Matthias On 3/8/18 10:36 PM, Guozhang Wang wrote: > Thanks Matthias, that sounds good to me. I'm +1 on the KIP itsel

Re: [VOTE] KIP-251: Allow timestamp manipulation in Processor API

2018-03-08 Thread Guozhang Wang
Thanks Matthias, that sounds good to me. I'm +1 on the KIP itself. Guozhang On Thu, Mar 8, 2018 at 5:46 PM, Matthias J. Sax wrote: > Guozhang, > > I updated the code slightly to avoid object creation and I did some perf > investigations. > > 1) JMH Benchmark with the below topology using Topol

Re: [VOTE] KIP-251: Allow timestamp manipulation in Processor API

2018-03-08 Thread Matthias J. Sax
Guozhang, I updated the code slightly to avoid object creation and I did some perf investigations. 1) JMH Benchmark with the below topology using TopologyTestDriver to pipe data throw the topology: > StreamsBuilder builder = new StreamsBuilder(); > KStream stream = builder.stream

Re: [VOTE] KIP-251: Allow timestamp manipulation in Processor API

2018-02-11 Thread Guozhang Wang
Hi Matthias, Just clarifying a meta question along side with my vote: we still need to understand the overhead of the `To` objects during run time to determine whether we would use it in the final proposal or using overloading functions. Right? Guozhang On Sun, Feb 11, 2018 at 9:33 PM, Guozhang

Re: [VOTE] KIP-251: Allow timestamp manipulation in Processor API

2018-02-11 Thread Guozhang Wang
+1 On Fri, Feb 9, 2018 at 5:31 AM, Bill Bejeck wrote: > Thanks for the KIP, +1 for me. > > -Bill > > On Fri, Feb 9, 2018 at 6:45 AM, Damian Guy wrote: > > > Thanks Matthias, +1 > > > > On Fri, 9 Feb 2018 at 02:42 Ted Yu wrote: > > > > > +1 > > > Original message From: "Matthia

Re: [VOTE] KIP-251: Allow timestamp manipulation in Processor API

2018-02-09 Thread Bill Bejeck
Thanks for the KIP, +1 for me. -Bill On Fri, Feb 9, 2018 at 6:45 AM, Damian Guy wrote: > Thanks Matthias, +1 > > On Fri, 9 Feb 2018 at 02:42 Ted Yu wrote: > > > +1 > > Original message From: "Matthias J. Sax" < > > matth...@confluent.io> Date: 2/8/18 6:05 PM (GMT-08:00) To:

Re: [VOTE] KIP-251: Allow timestamp manipulation in Processor API

2018-02-09 Thread Damian Guy
Thanks Matthias, +1 On Fri, 9 Feb 2018 at 02:42 Ted Yu wrote: > +1 > Original message From: "Matthias J. Sax" < > matth...@confluent.io> Date: 2/8/18 6:05 PM (GMT-08:00) To: > dev@kafka.apache.org Subject: [VOTE] KIP-251: Allow timestamp > manipulation in Processor API > Hi, >

Re: [VOTE] KIP-251: Allow timestamp manipulation in Processor API

2018-02-08 Thread Ted Yu
+1 Original message From: "Matthias J. Sax" Date: 2/8/18 6:05 PM (GMT-08:00) To: dev@kafka.apache.org Subject: [VOTE] KIP-251: Allow timestamp manipulation in Processor API Hi, I want to start the vote for KIP-251: https://cwiki.apache.org/confluence/display/KAFKA/KIP-251%3