+1 (non-binding)
I really like the new API.
One thing to clarify in the docs:
"If sender thread calls close(), it will block forever. So if a
close() call is called from sender thread, an error message will be
put in the log and close(0) will be called instead."
I think we should explicitly ment
+1
On Fri, Mar 27, 2015 at 01:34:54PM -0700, Neha Narkhede wrote:
> +1
>
> Thanks Becket!
>
> On Fri, Mar 27, 2015 at 1:19 PM, Jay Kreps wrote:
>
> > +1
> >
> > Thanks for your patience Jiangjie!
> >
> > -Jay
> >
> > On Fri, Mar 27, 2015 at 11:48 AM, Jiangjie Qin
> > wrote:
> >
> > >
> > >
>
+1
Thanks Becket!
On Fri, Mar 27, 2015 at 1:19 PM, Jay Kreps wrote:
> +1
>
> Thanks for your patience Jiangjie!
>
> -Jay
>
> On Fri, Mar 27, 2015 at 11:48 AM, Jiangjie Qin
> wrote:
>
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-15+-+Add+a+close+method+with+a+timeout+in+the+p
+1
Thanks for your patience Jiangjie!
-Jay
On Fri, Mar 27, 2015 at 11:48 AM, Jiangjie Qin
wrote:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-15+-+Add+a+close+method+with+a+timeout+in+the+producer
>
> Let us vote again!
>
