Re: [VOTE] KIP-113 - Support replicas movement between log directories

2017-06-06 Thread Dong Lin
Thanks to everyone who voted and provided feedback! This KIP is now adopted with 3 binding +1s (Jun, Joel, Becket) On Tue, Jun 6, 2017 at 10:36 AM, Becket Qin wrote: > +1 > > Thanks for the KIP, Dong. > > On Tue, Jun 6, 2017 at 10:20 AM, Jun Rao wrote: > > > Hi, Dong, > > > > Thanks for the KI

Re: [VOTE] KIP-113 - Support replicas movement between log directories

2017-06-06 Thread Becket Qin
+1 Thanks for the KIP, Dong. On Tue, Jun 6, 2017 at 10:20 AM, Jun Rao wrote: > Hi, Dong, > > Thanks for the KIP. +1 from me. > > Jun > > On Mon, Apr 3, 2017 at 9:49 AM, Dong Lin wrote: > > > Hi all, > > > > It seems that there is no further concern with the KIP-113. We would like > > to start

Re: [VOTE] KIP-113 - Support replicas movement between log directories

2017-06-06 Thread Jun Rao
Hi, Dong, Thanks for the KIP. +1 from me. Jun On Mon, Apr 3, 2017 at 9:49 AM, Dong Lin wrote: > Hi all, > > It seems that there is no further concern with the KIP-113. We would like > to start the voting process. The KIP can be found at > *https://cwiki.apache.org/confluence/display/KAFKA/KIP-

Re: [VOTE] KIP-113 - Support replicas movement between log directories

2017-06-03 Thread Dong Lin
Hey Joel, Thanks much for the review! I have updated the KIP to address all your comments. Please find the diff here . Regards, Dong On Sat, Jun 3, 2017 at 11:43

Re: [VOTE] KIP-113 - Support replicas movement between log directories

2017-06-03 Thread Joel Koshy
+1 Few additional comments (most of which we discussed offline): - This was summarized in the “discuss” thread, but it is worth recording in the KIP itself that the LEO in DescribeDirsResponse is useful to measure progress of the move. - num.replica.move.threads defaults to #