Re: [VOTE] KIP-1054: Support external schemas in JSONConverter

2025-03-15 Thread Edoardo Comar
Hi Priyanka, I see I am fashionably late for this party, but, still ... Thank you for the KIP. +1 (binding) Edo On Wed, 23 Oct 2024 at 18:00, Greg Harris wrote: > > Hi Priyanka, > > This is definitely an improvement for single-schema Connectors, and simple > to configure. > I think mutable or

Re: [VOTE] KIP-1054: Support external schemas in JSONConverter

2024-10-23 Thread Greg Harris
Hi Priyanka, This is definitely an improvement for single-schema Connectors, and simple to configure. I think mutable or multiple schemas are fair to consider out-of-scope, as they are currently served by the existing schema management tooling and would complicate this design. I'm also interested

Re: [VOTE] KIP-1054: Support external schemas in JSONConverter

2024-10-15 Thread Chris Egerton
Hi Priyanka, Sorry for the delay! +1 (binding), thanks for the KIP. Cheers, Chris On Wed, Sep 4, 2024, 01:35 Priyanka K U wrote: > Hi Everyone, > > Please go through the proposal and requesting everyone to support with > your votes : > https://cwiki.apache.org/confluence/display/KAFKA/KIP-10

RE: [VOTE] KIP-1054: Support external schemas in JSONConverter

2024-07-17 Thread Priyanka K U
;: [{ \"field\": \"id\", \"type\": \"string\", \"optional\": false },{ \"field\": \"name\", \"type\": \"string\", \"optional\": false }]}" } } Thanks, Priyanka. From: Chris Egerton Date: Wednes

Re: [VOTE] KIP-1054: Support external schemas in JSONConverter

2024-07-10 Thread Chris Egerton
rties file, > as well as embedding an inline schema directly within the connector > properties file . > > Thanks, > Priyanka > > From: Chris Egerton > Date: Friday, 5 July 2024 at 5:55 PM > To: dev@kafka.apache.org > Subject: [EXTERNAL] Re: [VOTE] KIP-1054: Support e

RE: [VOTE] KIP-1054: Support external schemas in JSONConverter

2024-07-10 Thread Priyanka K U
Date: Friday, 5 July 2024 at 5:55 PM To: dev@kafka.apache.org Subject: [EXTERNAL] Re: [VOTE] KIP-1054: Support external schemas in JSONConverter Hi Priyanka, How exactly did you test this feature? Was it in standalone mode (with a Java properties file), or with a JSON config submitted via the

Re: [VOTE] KIP-1054: Support external schemas in JSONConverter

2024-07-05 Thread Chris Egerton
gt; > From: Chris Egerton > Date: Saturday, 29 June 2024 at 12:37 PM > To: dev@kafka.apache.org > Subject: [EXTERNAL] Re: [VOTE] KIP-1054: Support external schemas in > JSONConverter > Hi Priyanka, > > I think allowing a raw schema string, instead of introducing a property

RE: [VOTE] KIP-1054: Support external schemas in JSONConverter

2024-07-05 Thread Priyanka K U
Egerton Date: Saturday, 29 June 2024 at 12:37 PM To: dev@kafka.apache.org Subject: [EXTERNAL] Re: [VOTE] KIP-1054: Support external schemas in JSONConverter Hi Priyanka, I think allowing a raw schema string, instead of introducing a property that gives users access to the file system on the

Re: [VOTE] KIP-1054: Support external schemas in JSONConverter

2024-06-29 Thread Chris Egerton
Hi Priyanka, I think allowing a raw schema string, instead of introducing a property that gives users access to the file system on the worker, is a good idea. I have two small thoughts: 1) The KIP provides an example of schema.content:${directory:/schema/schema.json} for how a config provider mig

Re: [VOTE] KIP-1054: Support external schemas in JSONConverter

2024-06-28 Thread Priyanka K U
Hello Everyone, I'd like to start a vote on KIP-1054, which aims to Support external schemas in JSONConverter to Kafka Connect: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1054%3A+Support+external+schemas+in+JSONConverter Thank you, Priyanka