Re: [DISCUSS] error handling in java KafkaProducer

2015-04-14 Thread Steven Wu
I submitted a patch attempt in the jira. On Tue, Apr 14, 2015 at 10:16 AM, Steven Wu wrote: > Thanks, Ewen and Guozhang! > > I will go with the try-catch option then. here is the jira. feel free to > assign it to me. I will try to submit a patch this week. > https://issues.apache.org/jira/browse

Re: [DISCUSS] error handling in java KafkaProducer

2015-04-14 Thread Steven Wu
Thanks, Ewen and Guozhang! I will go with the try-catch option then. here is the jira. feel free to assign it to me. I will try to submit a patch this week. https://issues.apache.org/jira/browse/KAFKA-2121 On Mon, Apr 13, 2015 at 7:17 PM, Guozhang Wang wrote: > It is a valid problem and we shou

Re: [DISCUSS] error handling in java KafkaProducer

2015-04-13 Thread Guozhang Wang
It is a valid problem and we should correct it as soon as possible, I'm with Ewen regarding the solution. On Mon, Apr 13, 2015 at 5:05 PM, Ewen Cheslack-Postava wrote: > Steven, > > Looks like there is even more that could potentially be leaked -- since key > and value serializers are created an

Re: [DISCUSS] error handling in java KafkaProducer

2015-04-13 Thread Ewen Cheslack-Postava
Steven, Looks like there is even more that could potentially be leaked -- since key and value serializers are created and configured at the end, even the IO thread allocated by the producer could leak. Given that, I think 1 isn't a great option since, as you said, it doesn't really address the und