Re: [DISCUSS] KIP-959 Add BooleanConverter to Kafka Connect

2023-07-25 Thread Chris Egerton
s to the companion PR [ > https://github.com/apache/kafka/pull/14093], and will mark it as "Ready > for Review" in a few. > > Cheers > > From: dev@kafka.apache.org At: 07/25/23 10:42:58 UTC-4:00To: > dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-959 Add Boolean

Re: [DISCUSS] KIP-959 Add BooleanConverter to Kafka Connect

2023-07-25 Thread Hector Geraldino (BLOOMBERG/ 919 3RD A)
apache.org At: 07/25/23 10:42:58 UTC-4:00To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-959 Add BooleanConverter to Kafka Connect Hi Hector, Thanks for the KIP! Really appreciate the tight scope, hoping this will be easy to review :) I only have one question: it looks like our existing

Re: [DISCUSS] KIP-959 Add BooleanConverter to Kafka Connect

2023-07-25 Thread Chris Egerton
Hi Hector, Thanks for the KIP! Really appreciate the tight scope, hoping this will be easy to review :) I only have one question: it looks like our existing primitive converters (string converter + subclasses of NumberConverter) are hardcoded to play nicely with null values during deserialization