On Sun, Jun 4, 2023, at 04:10, Divij Vaidya wrote:
> Thanks for the KIP Colin. I liked the rationale section which clearly
> explains why the metrics are required and what they might indicate.
>
> 1. I have a question about the "CurrentMetadataVersion" metric. Correct
> me
> if I'm wrong, but I as
Thanks for the KIP Colin. I liked the rationale section which clearly
explains why the metrics are required and what they might indicate.
1. I have a question about the "CurrentMetadataVersion" metric. Correct me
if I'm wrong, but I assume that we are referring to
https://github.com/apache/kafka/b
Thanks for the clarification and explanation, Colin. Looks good to me.
Ron
On Fri, Jun 2, 2023 at 2:52 PM Colin McCabe wrote:
>
> Hi Ron,
>
> Thanks for the review.
>
> On Fri, Jun 2, 2023, at 11:26, Ron Dagostino wrote:
> > Thanks for the KIP, Colin. The KIP cals one metric
> > "NewActiveCont
Hi Ron,
Thanks for the review.
On Fri, Jun 2, 2023, at 11:26, Ron Dagostino wrote:
> Thanks for the KIP, Colin. The KIP cals one metric
> "NewActiveControllersCount" but we don't append "Count" to the other
> metric names (e.g. it is "TimedOutBrokerHeartbeats" instead of
> "TimedOutBrokerHeartbe
Thanks for the KIP, Colin. The KIP cals one metric
"NewActiveControllersCount" but we don't append "Count" to the other
metric names (e.g. it is "TimedOutBrokerHeartbeats" instead of
"TimedOutBrokerHeartbeatsCount"). Should we be consistent (either use
the suffix everywhere or don't use it anywhe
