Re: [DISCUSS] KIP-911: Add source tag to MirrorSourceConnector metrics

2023-03-13 Thread Mickael Maison
Hi, Since it's a very small KIP, if there's no other feedback I'll start a vote in the next couple of days. Thanks, Mickael On Wed, Mar 8, 2023 at 10:20 PM Mickael Maison wrote: > > Hi Chris, > > Thanks for taking a look at the KIP. > I've removed the mention to the update mode. It was copied f

Re: [DISCUSS] KIP-911: Add source tag to MirrorSourceConnector metrics

2023-03-08 Thread Mickael Maison
Hi Chris, Thanks for taking a look at the KIP. I've removed the mention to the update mode. It was copied from somewhere else and I forgot to delete it. Thanks, Mickael On Wed, Mar 8, 2023 at 7:26 PM Chris Egerton wrote: > > Hi Mickael, > > Thanks for the KIP! LGTM. > > I find the rationales fo

Re: [DISCUSS] KIP-911: Add source tag to MirrorSourceConnector metrics

2023-03-08 Thread Chris Egerton
Hi Mickael, Thanks for the KIP! LGTM. I find the rationales for the rejected alternatives convincing, and agree with the deprecation plan and opt-in behavior for pre-4.0 releases. I also appreciate the historical context provided in the motivation section about why we don't already use a tag for