Re: [DISCUSS] KIP-760: Increase minimum value of segment.ms and segment.bytes

2021-07-08 Thread Kamal Chandraprakash
Badai, Thanks for the KIP! This is useful to avoid crashes in production scenarios. If someone still wants to quickly roll the log segments in test env, then they can do it by configuring the index.interval.bytes and segment.index.bytes to low value to force the log roll. -- Kamal On Thu, J

Re: [DISCUSS] KIP-760: Increase minimum value of segment.ms and segment.bytes

2021-07-07 Thread Badai Aqrandista
Ryanne/James Yes, the proposed values are kinda arbitrary. I just want to prevent users from setting segment.ms to 1 ms or segment.bytes to 1 byte, which will blow the file handles count and crash the broker. Because of that and James' input, I have updated the KIP to add broker configuration to

Re: [DISCUSS] KIP-760: Increase minimum value of segment.ms and segment.bytes

2021-07-07 Thread Ryanne Dolan
Badai, the KIP makes sense to me, but could you maybe add some evidence to support your proposed values? I'm sure they come from experience but I don't think they are obvious and so may appear arbitrary. Ryanne On Tue, Jul 6, 2021, 4:23 PM Badai Aqrandista wrote: > Hi all > > I have just creat

Re: [DISCUSS] KIP-760: Increase minimum value of segment.ms and segment.bytes

2021-07-06 Thread Badai Aqrandista
James Thank you for replying. I originally thought about adding two new broker dynamic config to allow administrator to determine the acceptable minimum: min.topic.segment.ms min.topic.segment.bytes I put this in the "rejected alternatives" section because I think adding two more configs to the

Re: [DISCUSS] KIP-760: Increase minimum value of segment.ms and segment.bytes

2021-07-06 Thread James Cheng
Badai, Thanks for the KIP. We sometimes want to force compaction on a topic. This might be because there is a bad record in the topic, and we want to force it to get deleted. The way we do this is, we set segment.ms to a small value and write a record, in order to force a segment roll. And we