Re: [DISCUSS] KIP-363: Make FunctionConversions private

I'm also in favor of this. I don't think it's controversial either. Should we just move to a vote? On Thu, Aug 23, 2018 at 7:01 PM Guozhang Wang wrote: > +1. > > On Thu, Aug 23, 2018 at 12:47 PM, Ted Yu wrote: > > > +1 > > > > In the Motivation section, you can quote the comment from pull reque

Re: [DISCUSS] KIP-363: Make FunctionConversions private

+1. On Thu, Aug 23, 2018 at 12:47 PM, Ted Yu wrote: > +1 > > In the Motivation section, you can quote the comment from pull request so > that reader doesn't have to click through. > > Cheers > > On Thu, Aug 23, 2018 at 12:13 PM Joan Goyeau wrote: > > > Hi, > > > > As pointed out in this comment

Re: [DISCUSS] KIP-363: Make FunctionConversions private

+1 In the Motivation section, you can quote the comment from pull request so that reader doesn't have to click through. Cheers On Thu, Aug 23, 2018 at 12:13 PM Joan Goyeau wrote: > Hi, > > As pointed out in this comment #5539 (comment) >