NP. Thanks!
On 6/26/18 2:54 PM, John Roesler wrote:
> Sorry for the misunderstanding, Matthias.
>
> I have created https://issues.apache.org/jira/browse/KAFKA-7106 and
> https://issues.apache.org/jira/browse/KAFKA-7107 to track these issues.
>
> Thanks,
> -John
>
> On Mon, Jun 25, 2018 at 10:06
Sorry for the misunderstanding, Matthias.
I have created https://issues.apache.org/jira/browse/KAFKA-7106 and
https://issues.apache.org/jira/browse/KAFKA-7107 to track these issues.
Thanks,
-John
On Mon, Jun 25, 2018 at 10:06 PM Matthias J. Sax
wrote:
> KAFKA-7080 is for this KIP.
>
> I meant
KAFKA-7080 is for this KIP.
I meant to create a JIRA to add `segmentInterval` to `Materialized` and
a JIRA to add `Materialized` to `KStream#join(KStream)`.
Thx.
-Matthias
On 6/25/18 2:46 PM, John Roesler wrote:
> Ah, it turns out I did create a ticket: it's KAFKA-7080:
> https://issues.apache
Ah, it turns out I did create a ticket: it's KAFKA-7080:
https://issues.apache.org/jira/browse/KAFKA-7080
-John
On Mon, Jun 25, 2018 at 4:44 PM John Roesler wrote:
> Matthias,
>
> That's a good idea. I'm not sure why I didn't...
>
> Thanks,
> -John
>
> On Mon, Jun 25, 2018 at 4:35 PM Matthias J
Matthias,
That's a good idea. I'm not sure why I didn't...
Thanks,
-John
On Mon, Jun 25, 2018 at 4:35 PM Matthias J. Sax
wrote:
> Ok.
>
> @John: can you create a JIRA to track this? I think KAFKA-4730 is
> related, but actually an own ticket (that is blocked by not having
> Materialized for st
Ok.
@John: can you create a JIRA to track this? I think KAFKA-4730 is
related, but actually an own ticket (that is blocked by not having
Materialized for stream-stream joins).
-Matthias
On 6/25/18 2:10 PM, Bill Bejeck wrote:
> I agree that it makes sense to have segmentInterval as a parameter t
I agree that it makes sense to have segmentInterval as a parameter to a
store, but I also agree with Guozhang's point about not moving as part of
this KIP.
Thanks,
Bill
On Mon, Jun 25, 2018 at 4:17 PM John Roesler wrote:
> Thanks Matthias and Guozhang,
>
> About deprecating the "segments" field
Thanks Matthias and Guozhang,
About deprecating the "segments" field instead of making it private. Yes, I
just took another look at the code, and that is correct. I'll update the
KIP.
I do agree that in the long run, it makes more sense as a parameter to the
store somehow than as a parameter to t
Re `segmentInterval` parameter in Windows: currently it is used in two
places, the windowed stream aggregation, and the stream-stream joins. For
the former, we can potentially move the parameter from windowedBy() to
Materialized, but for the latter we currently do not expose a Materialized
object y
Thanks for the KIP. Overall, I think it makes sense to clean up the API.
Couple of comments:
> Sadly there's no way to "deprecate" this
> exposure
I disagree. We can just mark the variable as deprecated and I advocate
to do this. When the deprecation period passed, we can make it private
(or act
Thanks John.
On Fri, Jun 22, 2018 at 5:05 PM, John Roesler wrote:
> Thanks for the feedback, Bill and Guozhang,
>
> I've updated the KIP accordingly.
>
> Thanks,
> -John
>
> On Fri, Jun 22, 2018 at 5:51 PM Guozhang Wang wrote:
>
> > Thanks for the KIP. I'm +1 on the proposal. One minor comment
Thanks for the feedback, Bill and Guozhang,
I've updated the KIP accordingly.
Thanks,
-John
On Fri, Jun 22, 2018 at 5:51 PM Guozhang Wang wrote:
> Thanks for the KIP. I'm +1 on the proposal. One minor comment on the wiki:
> the `In Windows, we will:` section code snippet is empty.
>
> On Fri,
Thanks for the KIP. I'm +1 on the proposal. One minor comment on the wiki:
the `In Windows, we will:` section code snippet is empty.
On Fri, Jun 22, 2018 at 3:29 PM, Bill Bejeck wrote:
> Hi John,
>
> Thanks for the KIP, and overall it's a +1 for me.
>
> In the JavaDoc for the segmentInterval met
Hi John,
Thanks for the KIP, and overall it's a +1 for me.
In the JavaDoc for the segmentInterval method, there's no mention of the
number of segments there can be at any one time. While it's implied that
the number of segments is potentially unbounded, would be better to
explicitly state that t
I've updated the KIP and draft PR accordingly.
On Thu, Jun 21, 2018 at 2:03 PM John Roesler wrote:
> Interesting... I did not initially consider it because I didn't want to
> have an impact on anyone's Streams apps, but now I see that unless
> developers have subclassed `Windows`, the number of
bq. propose just to make it private
+1
On Thu, Jun 21, 2018 at 12:03 PM, John Roesler wrote:
> Interesting... I did not initially consider it because I didn't want to
> have an impact on anyone's Streams apps, but now I see that unless
> developers have subclassed `Windows`, the number of segme
Hi Ted,
Ok, I also prefer it, and I find this reasoning compelling.
Thanks,
-John
On Thu, Jun 21, 2018 at 3:40 AM Ted Yu wrote:
> Window is a common term used in various streaming processing systems whose
> unit is time unit.
>
> Segment doesn't seem to be as widely used in such context.
> I t
Interesting... I did not initially consider it because I didn't want to
have an impact on anyone's Streams apps, but now I see that unless
developers have subclassed `Windows`, the number of segments would always
be 3!
There's one caveat to this, which I think was a mistake. The field
`segments` i
Window is a common term used in various streaming processing systems whose
unit is time unit.
Segment doesn't seem to be as widely used in such context.
I think using interval in the method name would clearly convey the meaning
intuitively.
Thanks
On Wed, Jun 20, 2018 at 1:31 PM, John Roesler
Hello John,
Thanks for the KIP.
Should we consider making the change on `Stores#persistentWindowStore`
parameters as well?
Guozhang
On Wed, Jun 20, 2018 at 1:31 PM, John Roesler wrote:
> Hi Ted,
>
> Ah, when you made that comment to me before, I thought you meant as opposed
> to "segments".
Hi Ted,
Ah, when you made that comment to me before, I thought you meant as opposed
to "segments". Now it makes sense that you meant as opposed to
"segmentSize".
I named it that way to match the peer method "windowSize", which is also a
quantity of milliseconds.
I agree that "interval" is more i
Normally size is not measured in time unit, such as milliseconds.
How about naming the new method segmentInterval ?
Thanks
Original message From: John Roesler Date:
6/20/18 10:45 AM (GMT-08:00) To: dev@kafka.apache.org Subject: [DISCUSS]
KIP-319: Replace segments with segment
22 matches
Mail list logo
